Codecov Report

Merging #421 (4fe9b8e) into main (b8aee0e) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #421   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines          599       599           
=========================================
  Hits           599       599           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

🤔 weird. I'm running the commands within the Review App on my local machine in a sequential fashion and it seems to deploy properly

Although, when trying to re-deploy again, it hangs when trying to attach the db to the app. This is because the database already exists.

$ flyctl postgres attach mvp-db -a mvp-pr-421    
                        
Checking for existing attachments
? Database "mvp_pr_421" already exists. Continue with the attachment process? Yes
Error: database user "mvp_pr_421" already exists. Please specify a new database user via --database-user

Even if I try to destroy it, I get the same error...

$ fly apps destroy mvp-pr-421     

Running fly pg db list -a mvp-db to list all databases yields this:

NAME                USERS 
mvp                   < too many users to list >
mvp_pr_         
mvp_pr_344      
mvp_pr_345      
mvp_pr_352      
mvp_pr_354      
mvp_pr_372      
mvp_pr_375      
mvp_pr_377      
mvp_pr_378      
mvp_pr_380      
mvp_pr_386      
mvp_pr_421      
mvp_review_test 
postgres        

@LuchoTurtle the biggest issue with review apps isn't even the deployment ...
it's the fact that WebSockets don't work on the review app which means LiveView is useless.

@nelsonic that wasn't detailed in the aforementioned issue, hence why I tried to open this PR. But it's a fruitless pursuit, might as well close this one off.

I don't mean you should close it. Sorry if that was unclear.
would love Review Apps to work seamlessly. 🙏
But I don't think it's a "quick" thing ...